On Wed, Apr 27, 2022 at 02:05:04PM -0700, Doug Anderson wrote: > Hi, > > On Tue, Apr 26, 2022 at 5:03 PM Matthias Kaehlcke <mka@xxxxxxxxxxxx> wrote: > > > > Add nodes for the onboard USB hub on trogdor devices. Remove the > > 'always-on' property from the hub regulator, since the regulator > > is now managed by the onboard_usb_hub driver. > > There are people out there that are running trogdor devices with > upstream Linux. There's not much we can do about it, but probably this > patch will cause them to fail to probe USB because they won't have > "CONFIG_USB_ONBOARD_HUB=y". Luckily the commit subject has "USB" in it > so hopefully it'll be easy to spot, but I wonder if we should add > something to the commit message that makes that super obvious and > tells them about the relevant commit, like: > > For anyone using trogdor-based devices on Linux, it should be noted > that this requires "CONFIG_USB_ONBOARD_HUB=y". Ok, I'll respin and add the note. > > Signed-off-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx> > > Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx> > > Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > > --- > > Depends on "usb: misc: Add onboard_usb_hub driver" [1] which landed in > > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?h=usb-testing > > > > This patch was split off the above series. > > > > [1] https://patchwork.kernel.org/project/linux-usb/list/?series=615531&state=%2A&archive=both > > I presume it will be moderately annoying if this lands in the Qualcomm > branch before the driver lands in mainline? Otherwise USB will fully > stop working on the Qualcomm branch. Do we want to postpone landing > this? Postponing the trogdor patch sounds good to me.
