On Wed, 27 Apr 2022, Caleb Connolly wrote: > > > On 26/04/2022 19:24, Lee Jones wrote: > > On Tue, 26 Apr 2022, Caleb Connolly wrote: > > > On 25/04/2022 16:05, Lee Jones wrote: > > > > On Wed, 23 Mar 2022, Caleb Connolly wrote: > > > > > > > > > From: Caleb Connolly <caleb.connolly@xxxxxxxxxx> > > > > > > > > > > The PMI8998 and PM660 expose the fab_id, this is needed by drivers like > > > > > the RRADC to calibrate ADC values. > > > > > > > > > > Signed-off-by: Caleb Connolly <caleb.connolly@xxxxxxxxxx> > > > > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > > > > Tested-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > > > > --- > > > > > drivers/mfd/qcom-spmi-pmic.c | 7 +++++++ > > > > > include/soc/qcom/qcom-spmi-pmic.h | 1 + > > > > > 2 files changed, 8 insertions(+) > > > > > > > > Please change the Subject line to match the style of the sub-system? > > > Hi, sorry if this is a silly question, I don't quite understand what you > > > want me to change here, the subject line is in the same "mfd: driver:" > > > format as other patches in the subsystem? > > > > mfd: qcom-spmi-pmic: Read fab ID on supported PMICs > > > > What's 'fab' should that be capitalised too? > "fab" is short for fabrication I think, the register value can be used to > determine which factory the chip was manufactured in. > > I can make it clearer and go for > > mfd: qcom-spmi-pmic: Read fabrication ID on supported PMICs Clearer, thanks. -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
