On 28/04/2022 07:49, Krzysztof Kozlowski wrote:
On 27/04/2022 20:40, Caleb Connolly wrote:
Add devicetree bindings for the Qualcomm PMI8998/PM660 SMB2 charger
driver.
Signed-off-by: Caleb Connolly <caleb.connolly@xxxxxxxxxx>
This should be a v2, because you already sent a patchset. You make it
for example with:
Argh, thanks, I'll resend.
`git format-patch -6 -v2`
and add changelog to cover-letter (which actually you did...).
---
.../power/supply/qcom,pmi8998-charger.yaml | 83 +++++++++++++++++++
1 file changed, 83 insertions(+)
create mode 100644 Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml
diff --git a/Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml b/Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml
new file mode 100644
index 000000000000..41b471713364
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml
@@ -0,0 +1,83 @@
+# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/power/supply/qcom,pmi8998-charger.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm PMI8998/PM660 Switch-Mode Battery Charger "2"
+
+maintainers:
+ - Caleb Connolly <caleb.connolly@xxxxxxxxxx>
+
+properties:
+ compatible:
+ enum:
+ - qcom,pmi8998-charger
+ - qcom,pm660-charger
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ minItems: 4
+ maxItems: 4
No need for minItems if it is equal to max. Skip the minItems, please.
Best regards,
Krzysztof
--
Kind Regards,
Caleb (they/he)
