On Thu, Apr 28, 2022 at 01:14:59PM +0530, Sai Prakash Ranjan wrote: > > > > Also, I see that this "disable the trace" feature has already been asked > > > > for for 2 other drivers in the Android kernel tree, why not include > > > > those changes here as well? That kind of shows that this new feature is > > > > limited in that driver authors are already wanting it disabled, even > > > > before it is accepted. > > > That can be done later on top of this series right? This series mainly deals with adding > > > initial support for such tracing, there could be numerous drivers who might or might > > > not want the feature which can be added onto later. We can't actually identify all > > > the driver requirements upfront. As an example, we have already used the flag to > > > disable tracing for nVHE KVM, so we know how to use the flag. > > Again, make it explicit in the driver file itself that it is doing this, > > not in the Makefile, and I will not have any objections. > > Ok, for kernel drivers I will make the define at the top of the .c driver file and include > those 2 driver changes in the series. Thank you, that is a much better way forward. greg k-h
