On 16.04.22 4:26, Leo Yan wrote:
It's fashion to use the icc_sync_state callback to notify the framework when all consumers are probed, so that the bandwidth request doesn't need to stay on maximum value. Do the same thing for msm8939 driver.
I assume that you tested this with some out of tree DT? Is it public? If the consumers are not described as such in DT and/or the support in the client drivers is missing, paths might get disabled. Thanks, Georgi
Signed-off-by: Leo Yan <leo.yan@xxxxxxxxxx> --- drivers/interconnect/qcom/msm8939.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/interconnect/qcom/msm8939.c b/drivers/interconnect/qcom/msm8939.c index f9c2d7d3100d..ca5f611d33b0 100644 --- a/drivers/interconnect/qcom/msm8939.c +++ b/drivers/interconnect/qcom/msm8939.c @@ -1423,6 +1423,7 @@ static struct platform_driver msm8939_noc_driver = { .driver = { .name = "qnoc-msm8939", .of_match_table = msm8939_noc_of_match, + .sync_state = icc_sync_state, }, }; module_platform_driver(msm8939_noc_driver);