Quoting Maxime Ripard (2022-04-22 02:48:17) > Hi, > > On Thu, Apr 21, 2022 at 07:49:12PM -0700, Stephen Boyd wrote: > > +Maxime > > > > Quoting Dmitry Baryshkov (2022-04-19 16:54:47) > > > Since the commit 948fb0969eae ("clk: Always clamp the rounded rate"), > > > the clk_core_determine_round_nolock() would clamp the requested rate > > > between min and max rates from the rate request. Normally these fields > > > would be filled by clk_core_get_boundaries() called from > > > clk_round_rate(). > > > > > > However clk_gfx3d_determine_rate() uses a manually crafted rate request, > > > which did not have these fields filled. Thus the requested frequency > > > would be clamped to 0, resulting in weird frequencies being requested > > > from the hardware. > > > > > > Fix this by filling min_rate and max_rate to the values valid for the > > > respective PLLs (0 and ULONG_MAX). > > > > > > Fixes: 948fb0969eae ("clk: Always clamp the rounded rate") > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > > --- > > > > I hope there aren't others like this lurking. > > The problem is larger than that (even though I overlooked this > particular issue), and addressed partially by patches 12-19 here: > https://lore.kernel.org/linux-clk/20220408091037.2041955-1-maxime@xxxxxxxxxx/ > > I wanted to have your feedback before fixing the relevant drivers, but > these are: Ok. Let me move the conversation over to that thread. I'm applying this to clk-fixes.