Thanks Dan, Your quick glance did spotted a good catch. This variable if un-necessary, A new version will be uploaded soon Thanks, Yaniv -----Original Message----- From: linux-scsi-owner@xxxxxxxxxxxxxxx [mailto:linux-scsi-owner@xxxxxxxxxxxxxxx] On Behalf Of Dan Aloni Sent: Saturday, August 16, 2014 8:33 PM To: Yaniv Gardi Cc: James.Bottomley@xxxxxxxxxxxxxxxxxxxxx; hch@xxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; linux-arm-msm@xxxxxxxxxxxxxxx; santoshsy@xxxxxxxxx; linux-scsi-owner@xxxxxxxxxxxxxxx; subhashj@xxxxxxxxxxxxxx; noag@xxxxxxxxxxxxxx; draviv@xxxxxxxxxxxxxx; Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; Kumar Gala; Vinayak Holikatti; James E.J. Bottomley; Grant Likely; Sujit Reddy Thumma; Sahitya Tummala; open list:OPEN FIRMWARE AND... Subject: Re: [PATCH v3] scsi: ufs-msm: add UFS controller support for Qualcomm MSM chips On Thu, Aug 14, 2014 at 05:22:18PM +0300, Yaniv Gardi wrote: > diff --git a/drivers/scsi/ufs/ufs-msm.h b/drivers/scsi/ufs/ufs-msm.h > new file mode 100644 index 0000000..6e93f1e > --- /dev/null > +++ b/drivers/scsi/ufs/ufs-msm.h > @@ -0,0 +1,158 @@ [...] > +}; > + > +static LIST_HEAD(phy_list); > + Just noticed this via a quick glance - Seems that this variable is not referenced by any of the compilation units, what's the purpose of it? And as a static global in a shared private, each of the including compilation units gets a copy, which I am not sure was intended anyway. -- Dan Aloni -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
