On Thu, 21 Apr 2022 at 09:04, Slark Xiao <slark_xiao@xxxxxxx> wrote: > > > > At 2022-04-20 20:00:23, "Loic Poulain" <loic.poulain@xxxxxxxxxx> wrote: > >Hi Slark, > > > >On Wed, 20 Apr 2022 at 12:28, Slark Xiao <slark_xiao@xxxxxxx> wrote: > >> > >> MV32-WA is designed based on Qualcomm SDX62, and > >> MV32-WB is designed based on QUalcomm SDX65. Both > >> products' enumeration would align with previous > >> product MV31-W. > >> Add some new items for mv32 to separate it from > >> mv31-w, in case we need to do any changes in > >> future. > > > >On the contrary, do not overly clone the structures, and re-use the > >mv31 ones if they apply. You can rename them to mv3x if you really > >want to. > > > >Regards, > >Loic > > > Hi Loic, > Thanks for your suggestion. > Actually, for different chip(like previous SDX24 and SDX55), they may > have difference behavior. For example, the item of 'sideband_wake' > of SDX24 is true but the rest is false. It's hard to say SDX65 would > align with SDX55 until now. I agree, but as long as the structure's fields are the same there is no point in duplicating them. > Maybe I can re-use the same item '.config' for all MV3X products and separate > them from device info(mhi_pci_dev_info). > Do you agree this? Yes. Loic
