On Tue, Apr 19, 2022 at 04:11:27PM -0500, Bjorn Andersson wrote: > On Mon 18 Apr 20:09 CDT 2022, Bryan O'Donoghue wrote: > [..] > > + > > +#include "msm8916-pins.dtsi" > > I thought we got rid of the separate *-pins.dtsi file. I'm also worried > about sharing this between 8916 and 8939. Can you please inline this in > line with one of the newer platform. Why is this worrying? AFAIK MSM8939 is pin-compatible with MSM8916, it uses the same pinctrl driver and compatible = "qcom,msm8916-pinctrl". You definitely need the same definitions when setting up device trees for 8939 devices. In fact most of the MSM8939 device trees that I have seen in the postmarketOS kernel fork look pretty much like the existing MSM8916 ones, just with the msm8916.dtsi include replaced with msm8939.dtsi. And I think that's a good thing for consistency and maintenance. :) I guess if we don't want separate -pins.dtsi anymore this just brings up the question again if parts of msm8916.dtsi and msm8939.dtsi should be shared in a .dtsi...
