On Tue, Apr 19, 2022 at 02:09:03AM +0100, Bryan O'Donoghue wrote: > Add a basic booting DTS for the Sony Xperia M4 Aqua aka "tulip". > > Tulip is paired with: > > - wcn3660 > - smb1360 battery charger > - 720p Truly NT35521 Panel > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > .../qcom/msm8939-sony-xperia-kanuti-tulip.dts | 489 ++++++++++++++++++ > 2 files changed, 490 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/msm8939-sony-xperia-kanuti-tulip.dts > > [...] > diff --git a/arch/arm64/boot/dts/qcom/msm8939-sony-xperia-kanuti-tulip.dts b/arch/arm64/boot/dts/qcom/msm8939-sony-xperia-kanuti-tulip.dts > new file mode 100644 > index 000000000000..336969f16bc9 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/msm8939-sony-xperia-kanuti-tulip.dts > @@ -0,0 +1,489 @@ > [...] > +&otg { > + status = "okay"; > + usb-role-switch; > + > + ulpi { > + usb_hs_phy: phy { > + qcom,enable-vbus-pullup; tulip seems to have qcom,usbid-gpio = <&msm_gpio 110 0>; downstream. Have you tried setting it up using linux,extcon-usb-gpio? See e.g. msm8916-longcheer-l8910, it has a similar setup (it also uses smb1360 for charging actually). The advantage is that you don't need the manual role switching using "usb-role-switch", USB OTG adapters should be detected automatically. Thanks, Stephan