On Wed, Apr 13, 2022 at 10:03:59AM +0300, Dmitry Baryshkov wrote:
> On Wed, 13 Apr 2022 at 05:38, Bjorn Andersson
> <bjorn.andersson@xxxxxxxxxx> wrote:
> >
> > On Thu 10 Mar 16:07 CST 2022, Ansuel Smith wrote:
> >
> > > Add compatible for ipq806x. Just like ipq4019, ipq806x doesn't require
> > > Core, Iface or Bus clock.
> > >
> > > Signed-off-by: Ansuel Smith <ansuelsmth@xxxxxxxxx>
> > > ---
> > > drivers/firmware/qcom_scm.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
> > > index 7db8066b19fd..7348c5894821 100644
> > > --- a/drivers/firmware/qcom_scm.c
> > > +++ b/drivers/firmware/qcom_scm.c
> > > @@ -1338,6 +1338,7 @@ static const struct of_device_id qcom_scm_dt_match[] = {
> > > SCM_HAS_IFACE_CLK |
> > > SCM_HAS_BUS_CLK)
> > > },
> > > + { .compatible = "qcom,scm-ipq806x" },
> >
> > If you in your dt do:
> >
> > compatible = "qcom,scm-ipq806x", "qcom,scm";
> >
> > Then we don't need to update the driver for each platform, only the DT
> > binding.
> >
> > And if we some day need to quirk something off qcom,scm-ipq806x we have
> > that option.
>
> I suppose that ipq806x might need SCM_HAS_CORE_CLK. Or, more likely,
> an interconnect vote, once we have interconnect drivers for
> ipq/apq8064 platforms.
>
