Quoting Satya Priya (2022-04-14 05:30:17) > diff --git a/arch/arm64/boot/dts/qcom/pm8008.dtsi b/arch/arm64/boot/dts/qcom/pm8008.dtsi > new file mode 100644 > index 0000000..7b4fe68 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/pm8008.dtsi > @@ -0,0 +1,42 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +// Copyright (c) 2022, The Linux Foundation. All rights reserved. > + > +&pm8008_bus { > + pm8008: pmic@8 { > + compatible = "qcom,pm8008"; > + reg = <0x8>; > + #address-cells = <1>; > + #size-cells = <0>; > + #interrupt-cells = <2>; > + > + pm8008_regulators: regulators { Container nodes without a compatible string are frowned upon. How about we add compatible = "qcom,pm8008-regulators" and then this can populated by the driver in the devm_of_platform_populate() call that's already there. > + pm8008_l1: ldo1 { > + regulator-name = "pm8008_l1"; > + }; > +