Hi,
On Tue, Apr 12, 2022 at 4:20 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote:
>
> @@ -519,8 +500,6 @@ static const struct of_device_id qnoc_of_match[] = {
> .data = &sc7180_dc_noc},
> { .compatible = "qcom,sc7180-gem-noc",
> .data = &sc7180_gem_noc},
> - { .compatible = "qcom,sc7180-ipa-virt",
> - .data = &sc7180_ipa_virt},
> { .compatible = "qcom,sc7180-mc-virt",
> .data = &sc7180_mc_virt},
> { .compatible = "qcom,sc7180-mmss-noc",
I have no objection to ${SUBJECT} change landing and based on all your
research and Alex's review/testing I think it's good to go.
However, now that you're removed the driver that cared about
"qcom,sc7180-ipa-virt", should we also be removing it from the
`bindings/interconnect/qcom,rpmh.yaml` file and the `sc7180.dtsi`
file? I think that removing it from _either_ the driver (like your
patch here does) _or_ the sc7180.dtsi file would fix the bug, right?
...and then removing it from the yaml would just be cleanup...
-Doug
