> This is something new and it seems only one SoC defines it (not even one
> BAM version). I wonder whether this is actually correct or this
> particular version of BAM is slightly different. Maybe someone could
> clarify it, but if no - looks ok.
Yes, sdm845.dtsi uses 4 entries and rest 1.
>
> > +
> > + num-channels:
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + description:
> > + Indicates supported number of DMA channels in a remotely controlled bam.
> > +
> > + qcom,controlled-remotely:
> > + $ref: /schemas/types.yaml#/definitions/flag
>
> type: boolean
Boolean comes under flag in types.yaml
definitions:
flag:
oneOf:
- type: boolean
const: true
- type: 'null'
I have seen other boolean properties(spi-cpol, spi-cpha and bunch of
others) using type flag. I think we should keep flag here.
>
> > + description:
> > + Indicates that the bam is controlled by remote proccessor i.e. execution
> > + environment.
> > +
> > + qcom,ee:
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + description:
> > + Indicates the active Execution Environment identifier (0-7) used in the
> > + secure world.
>
> maximum: 7
ok.
> > +required:
> > + - compatible
> > + - "#dma-cells"
> > + - interrupts
> > + - reg
>
> clocks, clock-names, qcom-ee - these are required according to old bindings.
I missed qcom,ee. Will add in v3.
For clocks and clock-names , there are two platforms(msm8996.dtsi,
sdm845.dtsi) where these properties are missing. And I don't want to add
some random values. Shall I skip them here? and let board owners add
them later.
