On 3/22/2022 1:56 AM, Stephen Boyd wrote:
Quoting Srinivasa Rao Mandadapu (2022-03-21 04:59:19)Add LPASS LPI pinctrl node required for Audio functionality on sc7280 based platforms. Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@xxxxxxxxxxx> Co-developed-by: Venkata Prasad Potturu <quic_potturu@xxxxxxxxxxx> Signed-off-by: Venkata Prasad Potturu <quic_potturu@xxxxxxxxxxx> --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 147 +++++++++++++++++++++++++++++++++++ 1 file changed, 147 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi index 8d8cec5..499299a 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi @@ -1987,6 +1987,153 @@ qcom,bcm-voters = <&apps_bcm_voter>; }; + lpass_tlmm: pinctrl@33c0000 { + compatible = "qcom,sc7280-lpass-lpi-pinctrl"; + reg = <0 0x33c0000 0x0 0x20000>, + <0 0x3550000 0x0 0x10000>; + gpio-controller; + #gpio-cells = <2>; + gpio-ranges = <&lpass_tlmm 0 0 15>; + + #clock-cells = <1>; + + dmic01_active: dmic01-active { + clk { + pins = "gpio6"; + function = "dmic1_clk"; + drive-strength = <8>; + output-high;The rule of thumb is that drive strength, output/input, and bias properties should be in the board file, because the board layout decides the drive strength, the output level could be inverted on the board, and the biasing could be done externally (or not) via pullup/pulldowns on the net. The gpio driver should be able to make pins into inputs automatically when the gpio is requested and used so having input or output is typically wrong and should be handled by the consumer driver.
Okay. will re arrange accordingly and remove output-high property.
+ }; + + data { + pins = "gpio7"; + function = "dmic1_data";So in the end I'd expect to only see pins and function properties in the SoC dtsi file.
Okay.
+ drive-strength = <8>; + }; + }; + + dmic01_sleep: dmic01-sleep { + clk { + pins = "gpio6"; + function = "dmic1_clk";
