Kalle Valo <kvalo@xxxxxxxxxx> writes:
> Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> writes:
>
>> Dragonboard845c doesn't have board-specific board-id programmed, it uses
>> generic 0xff. Thus add the property with the 'variant' of the
>> calibration data.
>>
>> Note: the driver will check for the calibration data for the following
>> IDs, so older board-2.bin files that were distributed as a part of
>> Linaro releases will continue to work.
>>
>> - 'bus=snoc,qmi-board-id=ff,qmi-chip-id=30214,variant=Thundercomm_DB845C'
>> - 'bus=snoc,qmi-board-id=ff,qmi-chip-id=30214'
>> - 'bus=snoc,qmi-board-id=ff'
>>
>> For the reference, the board is identified by the driver in the
>> following way:
>>
>> ath10k_snoc 18800000.wifi: qmi chip_id 0x30214 chip_family 0x4001 board_id 0xff soc_id 0x40030001
>> ath10k_snoc 18800000.wifi: qmi fw_version 0x2009856b fw_build_timestamp 2018-07-19 12:28 fw_build_id QC_IMAGE_VERSION_STRING=WLAN.HL.2.0-01387-QCAHLSWMTPLZ-1
>>
>> Fixes: 3f72e2d3e682 ("arm64: dts: qcom: Add Dragonboard 845c")
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
>> ---
>> arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
>> index 13f80a0b6faa..f49de3913dd5 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
>> @@ -1047,6 +1047,7 @@ &wifi {
>> vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
>>
>> qcom,snoc-host-cap-8bit-quirk;
>> + qcom,ath10k-calibration-variant = "Thundercomm_DB845C";
>
> I don't think I have documented it anywhere, but to keep things simple I
> would prefer to have the variant all lower case.
But, after thinking more, I guess that's water under the bridge now. So
please ignore my comment.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
