On 02/04/2022 21:44, Kuldeep Singh wrote: > On Sat, Apr 02, 2022 at 02:29:59PM +0200, Krzysztof Kozlowski wrote: >> On 02/04/2022 07:12, Kuldeep Singh wrote: >>> GENI(generic interface) based Qualcomm Universal Peripheral controller >>> can support multiple serial interfaces like spi,uart and i2c. >>> >>> + >>> + power-domains: >>> + maxItems: 1 >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> + required-opps: >>> + maxItems: 1 >> >> I have doubts this is correct property. Usually it is part of the >> opp-table. I see sc7180 needs this, but I think it is a mistake. Do you >> know how it is supposed to work? > > Not sure how exactly it works. I took reference from > Documentation/devicetree/bindings/clock/qcom,videocc.yaml on how to add > required-opps. > I see now that power domains consumer bindings also mention it: Documentation/devicetree/bindings/power/power_domain.txt and it might be actually used via __genpd_dev_pm_attach(). Let's keep it then. Best regards, Krzysztof
