On 02/04/2022 15:46, Rob Herring wrote: > On Fri, 01 Apr 2022 22:10:33 +0200, Krzysztof Kozlowski wrote: >> Convert the Qualcomm Shared Memory Driver bindings to DT Schema. >> >> Changes against original bindings: enforce only specific names of child >> nodes, instead of any names. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> --- >> .../regulator/qcom,smd-rpm-regulator.yaml | 2 +- >> .../bindings/remoteproc/qcom,q6v5.txt | 2 +- >> .../bindings/remoteproc/qcom,wcnss-pil.txt | 2 +- >> .../bindings/soc/qcom/qcom,smd-rpm.yaml | 4 +- >> .../devicetree/bindings/soc/qcom/qcom,smd.txt | 98 ------------- >> .../bindings/soc/qcom/qcom,smd.yaml | 137 ++++++++++++++++++ >> 6 files changed, 142 insertions(+), 103 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,smd.txt >> create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,smd.yaml >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/qcom/qcom,smd.example.dt.yaml: rpm-requests: 'clock-controller' does not match any of the regexes: 'pinctrl-[0-9]+' > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml > Documentation/devicetree/bindings/soc/qcom/qcom,smd.example.dt.yaml:0:0: /example-0/shared-memory/rpm/rpm-requests/clock-controller: failed to match any schema with compatible: ['qcom,rpmcc-msm8974', 'qcom,rpmcc'] > Documentation/devicetree/bindings/soc/qcom/qcom,smd.example.dt.yaml:0:0: /example-0/shared-memory/rpm/rpm-requests/clock-controller: failed to match any schema with compatible: ['qcom,rpmcc-msm8974', 'qcom,rpmcc'] These are being fixed by patch 9-10, so their order could be reversed to avoid the warnings. Best regards, Krzysztof