On 3/25/2022 11:18 PM, Stephen Boyd wrote:
Quoting Satya Priya (2022-03-25 04:58:11)
Add pm8008_infra and pm8008_regulators support for sc7280 idp.
Signed-off-by: Satya Priya <quic_c_skakit@xxxxxxxxxxx>
---
Changes in V6:
- No changes.
Changes in V7:
- No Changes.
Changes in V8:
- Add an extra phandle "pm8008_bus" and then include pm8008 dtsi files inside it.
- Remove output-high from pm8008_active node.
arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 70 ++++++++++++++++++++++++++++++++
1 file changed, 70 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
index ecbf2b8..0843e92 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
@@ -263,6 +263,67 @@
};
};
+pm8008_bus: &i2c1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
These two properties should already be in the i2c1 node. Can you remove
them?
Okay.
+ status = "okay";
+};
+
+&pm8008_bus {
+ #include "pm8008-infra.dtsi"
+ #include "pm8008-regulators.dtsi"
+};
I was thinking more of like
&pm8008_bus: &i2c1 {
status = "okay";
};
#include "pm8008.dtsi"
and then the nodes below.
You mean
pm8008_bus: &i2c1 {
status = "okay";
};
&pm8008_bus {
#include "pm8008.dtsi"
};
and remaining nodes, right?
