On 3/30/22 02:00, Rob Clark wrote: > +static int msm_ioctl_gem_info_set_iova(struct drm_device *dev, > + struct drm_file *file, struct drm_gem_object *obj, > + uint64_t iova) > +{ > + struct msm_drm_private *priv = dev->dev_private; > + struct msm_file_private *ctx = file->driver_priv; > + > + if (!priv->gpu) > + return -EINVAL; > + > + /* Only supported if per-process address space is supported: */ > + if (priv->gpu->aspace == ctx->aspace) > + return -EINVAL; nit: -EOPNOTSUPP ?