Hi Dmitry, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on rafael-pm/linux-next] [also build test WARNING on v5.17 next-20220325] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Dmitry-Baryshkov/cpufreq-qcom-hw-Fixes-for-cpu-hotplug-support/20220326-040226 base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20220326/202203261801.7gUYlIj3-lkp@xxxxxxxxx/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 0f6d9501cf49ce02937099350d08f20c4af86f3d) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm64 cross compiling tool for clang build # apt-get install binutils-aarch64-linux-gnu # https://github.com/0day-ci/linux/commit/0c1c62881dde7d4b3e6f74d8ab44f038f82f2f60 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Dmitry-Baryshkov/cpufreq-qcom-hw-Fixes-for-cpu-hotplug-support/20220326-040226 git checkout 0c1c62881dde7d4b3e6f74d8ab44f038f82f2f60 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/cpufreq/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): >> drivers/cpufreq/qcom-cpufreq-hw.c:314:54: warning: variable 'throttled_freq' is uninitialized when used here [-Wuninitialized] arch_update_thermal_pressure(policy->related_cpus, throttled_freq); ^~~~~~~~~~~~~~ drivers/cpufreq/qcom-cpufreq-hw.c:295:39: note: initialize the variable 'throttled_freq' to silence this warning unsigned long freq_hz, throttled_freq; ^ = 0 1 warning generated. vim +/throttled_freq +314 drivers/cpufreq/qcom-cpufreq-hw.c 275157b367f479 Thara Gopinath 2021-08-09 289 275157b367f479 Thara Gopinath 2021-08-09 290 static void qcom_lmh_dcvs_notify(struct qcom_cpufreq_data *data) 275157b367f479 Thara Gopinath 2021-08-09 291 { 275157b367f479 Thara Gopinath 2021-08-09 292 struct cpufreq_policy *policy = data->policy; 054b9f6e7282ce Dmitry Baryshkov 2022-03-25 293 int cpu = cpumask_first(policy->related_cpus); 275157b367f479 Thara Gopinath 2021-08-09 294 struct device *dev = get_cpu_device(cpu); 0258cb19c77deb Lukasz Luba 2021-11-09 295 unsigned long freq_hz, throttled_freq; 275157b367f479 Thara Gopinath 2021-08-09 296 struct dev_pm_opp *opp; 275157b367f479 Thara Gopinath 2021-08-09 297 unsigned int freq; 275157b367f479 Thara Gopinath 2021-08-09 298 275157b367f479 Thara Gopinath 2021-08-09 299 /* 275157b367f479 Thara Gopinath 2021-08-09 300 * Get the h/w throttled frequency, normalize it using the 275157b367f479 Thara Gopinath 2021-08-09 301 * registered opp table and use it to calculate thermal pressure. 275157b367f479 Thara Gopinath 2021-08-09 302 */ 275157b367f479 Thara Gopinath 2021-08-09 303 freq = qcom_lmh_get_throttle_freq(data); 275157b367f479 Thara Gopinath 2021-08-09 304 freq_hz = freq * HZ_PER_KHZ; 275157b367f479 Thara Gopinath 2021-08-09 305 275157b367f479 Thara Gopinath 2021-08-09 306 opp = dev_pm_opp_find_freq_floor(dev, &freq_hz); 275157b367f479 Thara Gopinath 2021-08-09 307 if (IS_ERR(opp) && PTR_ERR(opp) == -ERANGE) 0c1c62881dde7d Dmitry Baryshkov 2022-03-25 308 opp = dev_pm_opp_find_freq_ceil(dev, &freq_hz); 275157b367f479 Thara Gopinath 2021-08-09 309 0c1c62881dde7d Dmitry Baryshkov 2022-03-25 310 if (IS_ERR(opp)) { 0c1c62881dde7d Dmitry Baryshkov 2022-03-25 311 dev_warn(dev, "Can't find the OPP for throttling: %pe!\n", opp); 0c1c62881dde7d Dmitry Baryshkov 2022-03-25 312 } else { 0258cb19c77deb Lukasz Luba 2021-11-09 313 /* Update thermal pressure (the boost frequencies are accepted) */ 0258cb19c77deb Lukasz Luba 2021-11-09 @314 arch_update_thermal_pressure(policy->related_cpus, throttled_freq); 275157b367f479 Thara Gopinath 2021-08-09 315 0c1c62881dde7d Dmitry Baryshkov 2022-03-25 316 dev_pm_opp_put(opp); 0c1c62881dde7d Dmitry Baryshkov 2022-03-25 317 } 0c1c62881dde7d Dmitry Baryshkov 2022-03-25 318 275157b367f479 Thara Gopinath 2021-08-09 319 /* 275157b367f479 Thara Gopinath 2021-08-09 320 * In the unlikely case policy is unregistered do not enable 275157b367f479 Thara Gopinath 2021-08-09 321 * polling or h/w interrupt 275157b367f479 Thara Gopinath 2021-08-09 322 */ 275157b367f479 Thara Gopinath 2021-08-09 323 mutex_lock(&data->throttle_lock); 275157b367f479 Thara Gopinath 2021-08-09 324 if (data->cancel_throttle) 275157b367f479 Thara Gopinath 2021-08-09 325 goto out; 275157b367f479 Thara Gopinath 2021-08-09 326 275157b367f479 Thara Gopinath 2021-08-09 327 /* 275157b367f479 Thara Gopinath 2021-08-09 328 * If h/w throttled frequency is higher than what cpufreq has requested 275157b367f479 Thara Gopinath 2021-08-09 329 * for, then stop polling and switch back to interrupt mechanism. 275157b367f479 Thara Gopinath 2021-08-09 330 */ 275157b367f479 Thara Gopinath 2021-08-09 331 if (throttled_freq >= qcom_cpufreq_hw_get(cpu)) 275157b367f479 Thara Gopinath 2021-08-09 332 enable_irq(data->throttle_irq); 275157b367f479 Thara Gopinath 2021-08-09 333 else 275157b367f479 Thara Gopinath 2021-08-09 334 mod_delayed_work(system_highpri_wq, &data->throttle_work, 275157b367f479 Thara Gopinath 2021-08-09 335 msecs_to_jiffies(10)); 275157b367f479 Thara Gopinath 2021-08-09 336 275157b367f479 Thara Gopinath 2021-08-09 337 out: 275157b367f479 Thara Gopinath 2021-08-09 338 mutex_unlock(&data->throttle_lock); 275157b367f479 Thara Gopinath 2021-08-09 339 } 275157b367f479 Thara Gopinath 2021-08-09 340 -- 0-DAY CI Kernel Test Service https://01.org/lkp
