On 17-02-22, 23:37, Marijn Suijten wrote: > On 2022-02-10 16:04:20, Vinod Koul wrote: > > For DSC to work we typically need a 2,2,1 configuration. This should > > suffice for resolutions up to 4k. For more resolutions like 8k this won't > > work. > > > > Also, it is better to use 2 LMs and DSC instances as half width results > > in lesser power consumption as compared to single LM, DSC at full width. > > > > The panel has been tested only with 2,2,1 configuration, so for > > now we blindly create 2,2,1 topology when DSC is enabled > > > > Co-developed-by: Abhinav Kumar <abhinavk@xxxxxxxxxxxxxx> > > Signed-off-by: Abhinav Kumar <abhinavk@xxxxxxxxxxxxxx> > > Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx> > > --- > > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 13 +++++++++++++ > > drivers/gpu/drm/msm/msm_drv.h | 2 ++ > > 2 files changed, 15 insertions(+) > > > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > > index 95a7bf362e81..13ccb7b3cce5 100644 > > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > > @@ -574,8 +574,21 @@ static struct msm_display_topology dpu_encoder_get_topology( > > topology.num_enc = 0; > > topology.num_intf = intf_count; > > > > + if (dpu_enc->dsc) { > > + /* In case of Display Stream Compression DSC, we would use > > Just like elsewhere, since you wrote out Display Stream Compression, > write the "DSC" abbreviation between parentheses ()? Updated -- ~Vinod