On Mon, Mar 21, 2022 at 05:47:18PM -0700, David Collins wrote: > Add support to register SCMI regulator subnodes based on an SCMI > Voltage Domain name specified via the "arm,scmi-domain-name" device > tree property. In doing so, make the "reg" property optional with > the constraint that at least one of "reg" or "arm,scmi-domain-name" > must be specified. If both are specified, then both must match the > Voltage Domain data exposed by the SCMI platform. > Since the SCMI specification allows discovery of names based on the numbering scheme, we haven't added support for the name explicitly. However, I have heard/received couple of such feedback to provide name based access in private so far. So good to have this discussion in public. > Name based SCMI regulator registration helps ensure that an SCMI > agent doesn't need to be aware of the numbering scheme used for > Voltage Domains by the SCMI platform. While I understand the regulator framework has a good support for name based approach you prefer, I see other frameworks like clock rely on numbering scheme and I see quite a few qualcomm platforms upstream use the number scheme for clocks. So why is that a problem with regulator ? Another main issue I have is what if the firmware and DT end up with a mismatch say with a firmware upgrade or a DT update ? Basically out of sync between DT and the SCMI firmware. I see this as duplication of source of information and is always cause for the trouble. I don't want to end up with the quirks to deal with (totally unnecessary) issues this may create in long run. > It also ensures that the > correct Voltage Domain is selected for a given physical regulator. How is that done magically if I give wrong regulator name ? Sorry the way it is presented sounds like adding name fixes something that numerical ID alone will always break. > This cannot be guaranteed with numeric Voltage Domain IDs alone. > If the IDs are correct like the names, it is guaranteed. I see this ID vs name is more for some maintenance convenience because somewhere something else needs to changes or moved away from existing way of maintenance. That said, if others believe, this is useful, I am happy to consider esp. if there are more *real* reasons for doing this. Please add clock and other subsystem maintainers who also have numbering scheme as main mechanism in the upstream so that we get feedback from them too. -- Regards, Sudeep
