On Mon, Mar 21, 2022 at 04:41:37PM +0100, Krzysztof Kozlowski wrote:
> On 21/03/2022 15:48, Ansuel Smith wrote:
> > Convert kpss-gcc driver Documentation to yaml.
> >
> > Signed-off-by: Ansuel Smith <ansuelsmth@xxxxxxxxx>
> > ---
> > .../bindings/arm/msm/qcom,kpss-gcc.txt | 44 ------------
> > .../bindings/arm/msm/qcom,kpss-gcc.yaml | 68 +++++++++++++++++++
> > 2 files changed, 68 insertions(+), 44 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.txt
> > create mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.txt b/Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.txt
> > deleted file mode 100644
> > index e628758950e1..000000000000
> > --- a/Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.txt
> > +++ /dev/null
> > @@ -1,44 +0,0 @@
> > -Krait Processor Sub-system (KPSS) Global Clock Controller (GCC)
> > -
> > -PROPERTIES
> > -
> > -- compatible:
> > - Usage: required
> > - Value type: <string>
> > - Definition: should be one of the following. The generic compatible
> > - "qcom,kpss-gcc" should also be included.
> > - "qcom,kpss-gcc-ipq8064", "qcom,kpss-gcc"
> > - "qcom,kpss-gcc-apq8064", "qcom,kpss-gcc"
> > - "qcom,kpss-gcc-msm8974", "qcom,kpss-gcc"
> > - "qcom,kpss-gcc-msm8960", "qcom,kpss-gcc"
> > -
> > -- reg:
> > - Usage: required
> > - Value type: <prop-encoded-array>
> > - Definition: base address and size of the register region
> > -
> > -- clocks:
> > - Usage: required
> > - Value type: <prop-encoded-array>
> > - Definition: reference to the pll parents.
> > -
> > -- clock-names:
> > - Usage: required
> > - Value type: <stringlist>
> > - Definition: must be "pll8_vote", "pxo".
> > -
> > -- clock-output-names:
> > - Usage: required
> > - Value type: <string>
> > - Definition: Name of the output clock. Typically acpu_l2_aux indicating
> > - an L2 cache auxiliary clock.
> > -
> > -Example:
> > -
> > - l2cc: clock-controller@2011000 {
> > - compatible = "qcom,kpss-gcc-ipq8064", "qcom,kpss-gcc";
> > - reg = <0x2011000 0x1000>;
> > - clocks = <&gcc PLL8_VOTE>, <&gcc PXO_SRC>;
> > - clock-names = "pll8_vote", "pxo";
> > - clock-output-names = "acpu_l2_aux";
> > - };
> > diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.yaml b/Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.yaml
> > new file mode 100644
> > index 000000000000..20ee182eb16f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.yaml
> > @@ -0,0 +1,68 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/arm/msm/qcom,kpss-gcc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Krait Processor Sub-system (KPSS) Global Clock Controller (GCC)
> > +
> > +maintainers:
> > + - Ansuel Smith <ansuelsmth@xxxxxxxxx>
> > +
> > +description: |
> > + Krait Processor Sub-system (KPSS) Global Clock Controller (GCC). Used
> > + to control L2 mux (in the current implementation).
> > +
> > +properties:
> > + compatible:
> > + items:
> > + - enum:
> > + - qcom,kpss-gcc-ipq8064
> > + - qcom,kpss-gcc-apq8064
> > + - qcom,kpss-gcc-msm8974
> > + - qcom,kpss-gcc-msm8960
> > + - const: qcom,kpss-gcc
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + clocks:
> > + items:
> > + - description: phandle to pll8_vote
> > + - description: phandle to pxo_board
> > +
> > + clock-names:
> > + items:
> > + - const: pll8_vote
> > + - const: pxo
> > +
> > + clock-output-names:
> > + const: acpu_l2_aux
> > +
> > + '#clock-cells':
> > + const: 0
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - clocks
> > + - clock-names
> > + - clock-output-names
> > + - '#clock-cells'
>
> You add here a new required property, so this is not a pure conversion.
> Please explain in the commit msg why are you doing this. I asked about
> this in your previous patchset.
>
> Best regards,
> Krzysztof
Sorry I probably missed it. Just to make sure you are referring to
#clock-cells?
Since this expose a clock, clock-cells is required. Should I put this in
a different commit?
--
Ansuel
