On Tue, Mar 1, 2022 at 4:24 PM Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx> wrote: > > Hi Rob, > > On 2022-03-01 15:05:31, Rob Herring wrote: > > The MDSS interrupt provider is a single cell, so specifying interrupt flags > > on the consumers is incorrect. > > There seem to be many more violators of `#interrupt-cells = <1>;`, at > least on -next e6ada6df471f. It seems those are not intentionally > omitted in this patch? Searching for `interrupt-parent = <&mdss>;` > globally and evaluating `interrupts =` right next to it yields: > > - Two more hits in both sdm845.dtsi and sm8250.dtsi; > - qcom-msm8974.dtsi; > - msm8996.dtsi; > - sdm630.dtsi; > - sdm660.dtsi. > > And for the docs patch: > - mdp5.txt; Don't care, it's a .txt file. > - And the recently added dpu-qcm2290.yaml, whose CI failure might have > exactly lead to this patch? > > Would you mind cleaning these up in a v2, or otherwise explain and > forgive my ignorance for not seeing why these were not changed? For the rest, just inadequate searching on my part. v2 coming soon. Rob
