On 2/28/22 5:26 PM, Rob Herring wrote:
On Mon, 28 Feb 2022 14:02:57 +0200, Vladimir Zapolskiy wrote:
The change adds device tree bindings for camera clock controller
found on SM8450 SoC.
Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@xxxxxxxxxx>
---
.../bindings/clock/qcom,camcc-sm8450.yaml | 87 ++++++++++
include/dt-bindings/clock/qcom,camcc-sm8450.h | 159 ++++++++++++++++++
2 files changed, 246 insertions(+)
create mode 100644 Documentation/devicetree/bindings/clock/qcom,camcc-sm8450.yaml
create mode 100644 include/dt-bindings/clock/qcom,camcc-sm8450.h
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/clock/qcom,camcc-sm8450.example.dts:28.34-35 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:378: Documentation/devicetree/bindings/clock/qcom,camcc-sm8450.example.dt.yaml] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1398: dt_binding_check] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1598821
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
Apparently
#include <dt-bindings/power/qcom-rpmpd.h>
in the example is missing, thank you for the report.
--
Best wishes,
Vladimir
