Hi, Andersson: > Your patch solves the particular problem, so I'm applying it. > > But it seems that we never release pdev in the case of successfully > return the ocmem object either... So there's more to improve here. > Thanks for your time. Should I submit another patch to release pdev in the regular path? > > drivers/soc/qcom/ocmem.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/soc/qcom/ocmem.c b/drivers/soc/qcom/ocmem.c > > index d2dacbbaafbd..97fd24c178f8 100644 > > --- a/drivers/soc/qcom/ocmem.c > > +++ b/drivers/soc/qcom/ocmem.c > > @@ -206,6 +206,7 @@ struct ocmem *of_get_ocmem(struct device *dev) > > ocmem = platform_get_drvdata(pdev); > > if (!ocmem) { > > dev_err(dev, "Cannot get ocmem\n"); > > + put_device(&pdev->dev); > > return ERR_PTR(-ENODEV); > > } > > return ocmem; > > -- > > 2.17.1 > >