On Mon, Feb 28, 2022 at 06:00:18PM +0530, Bhupesh Sharma wrote: > Currently the qcom,qmp-phy dt-binding doesn't describe > the 'reg' and '#phy-cells' properties for the phy@ subnode. > > Fix the same. > > Cc: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > Cc: Rob Herring <robh@xxxxxxxxxx> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx> > --- > Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > index 70e7cd75e173..f8a43acd229a 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > @@ -115,6 +115,13 @@ patternProperties: > Each device node of QMP phy is required to have as many child nodes as > the number of lanes the PHY has. > properties: > + reg: > + minItems: 1 > + maxItems: 6 > + > + "#phy-cells": > + const: 0 > + > "#clock-cells": > enum: [ 0, 1, 2 ] While you are at it, what about these properties? clocks = <&gcc GCC_USB3_PRIM_PHY_PIPE_CLK>; clock-names = "pipe0"; clock-output-names = "usb3_phy_pipe_clk_src"; Shawn