Hi Alexey, On Fri, 28 Jan 2022 at 19:37, Alexey Minnekhanov <alexeymin@xxxxxxxxxxxxxxxx> wrote: > > At 20.01.2022 11:28, Bhupesh Sharma wrote: > > Add power-domain entries for UFS controller & phy nodes > > in sm8150 dts. > > > > ... > > + power-domains = <&gcc UFS_PHY_GDSC>; > > resets = <&gcc GCC_UFS_PHY_BCR>; > > reset-names = "rst"; > > ... > > + power-domains = <&gcc UFS_CARD_GDSC>, > > + <&gcc UFS_PHY_GDSC>; > > + power-domain-names = "ufs_card_gdsc", "ufs_phy_gdsc"; > > Strange, but I don't see neither UFS_PHY_GDSC nor UFS_CARD_GDSC in > gcc-sm8150.c [1] (and accordingly not in > include/dt-bindings/clock/qcom,gcc-sm8150.h), but they are present in > corresponding files for sm8250 [2]. > > By quick look at downstream sm8150-gdsc.dtsi addresses seem to be > similar to one used on sm8250, so I'm guessing gcc-sm8150 has to be > fixed first for this patch to work? You are right. I am sending a v2 shortly, which fixes this issue. Regards, Bhupesh