On 8/4/2014 7:20 AM, Kiran Padwal wrote: > This patch fixes the following checkpatch.pl warning: > > WARNING: braces {} are not necessary for any arm of this statement > > WARNING: Missing a blank line after declarations > > WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... > > WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... > > WARNING: else is not generally useful after a break or return > > WARNING: void function return statements are not generally useful > > Signed-off-by: Kiran Padwal <kiran.padwal@xxxxxxxxxxxxxxx> > --- > drivers/tty/serial/msm_serial.c | 26 +++++++++++--------------- > 1 file changed, 11 insertions(+), 15 deletions(-) Kiran, I have a series of fix patches against this file that is going to collide with your cleanups. Would you mind waiting until after I send my patches to do your clean up? Thanks, Frank -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html