Re: [PATCH v6 6/7] pinctrl: qcom: Add SC7280 lpass pin configuration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2/19/2022 8:13 AM, Stephen Boyd wrote:
Thanks for Your time Stephen!!!
Quoting Srinivasa Rao Mandadapu (2022-02-14 07:19:53)
diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c
new file mode 100644
index 0000000..5bf30d97
--- /dev/null
+++ b/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c
@@ -0,0 +1,169 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (c) 2020-2021, The Linux Foundation. All rights reserved.
+ * ALSA SoC platform-machine driver for QTi LPASS
+ */
+
+#include <linux/clk.h>
Drop unused include.
Okay. will remove it.

+#include <linux/gpio/driver.h>
+#include <linux/module.h>
+#include <linux/platform_device.h>
+
+#include "pinctrl-lpass-lpi.h"
include ../core.h
Okay. will add it.

+
+enum lpass_lpi_functions {
+       LPI_MUX_dmic1_clk,
+       LPI_MUX_dmic1_data,
+       LPI_MUX_dmic2_clk,
+       LPI_MUX_dmic2_data,
+       LPI_MUX_dmic3_clk,
+       LPI_MUX_dmic3_data,
+       LPI_MUX_i2s1_clk,
+       LPI_MUX_i2s1_data,
+       LPI_MUX_i2s1_ws,
+       LPI_MUX_i2s2_clk,
+       LPI_MUX_i2s2_data,
+       LPI_MUX_i2s2_ws,
+       LPI_MUX_qua_mi2s_data,
+       LPI_MUX_qua_mi2s_sclk,
+       LPI_MUX_qua_mi2s_ws,
+       LPI_MUX_swr_rx_clk,
+       LPI_MUX_swr_rx_data,
+       LPI_MUX_swr_tx_clk,
+       LPI_MUX_swr_tx_data,
+       LPI_MUX_wsa_swr_clk,
+       LPI_MUX_wsa_swr_data,
+       LPI_MUX_gpio,
+       LPI_MUX__,
+};
+
+static int gpio0_pins[] = { 0 };
const?
const giving conflicts with group_desc params.

+static int gpio1_pins[] = { 1 };
+static int gpio2_pins[] = { 2 };
+static int gpio3_pins[] = { 3 };
+static int gpio4_pins[] = { 4 };
+static int gpio5_pins[] = { 5 };
+static int gpio6_pins[] = { 6 };
+static int gpio7_pins[] = { 7 };



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux