Re: [PATCH v4 1/8] mfd: qcom-spmi-pmic: expose the PMIC revid information to clients

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

I've found some pretty bad bugs with this patch (specifically qcom_pmic_get()),
please do not merge, they'll be fixed in the next revision.

On 13/02/2022 16:55, Jonathan Cameron wrote:
On Fri, 11 Feb 2022 21:19:52 +0000
Caleb Connolly <caleb.connolly@xxxxxxxxxx> wrote:

Some PMIC functions such as the RRADC need to be aware of the PMIC
chip revision information to implement errata or otherwise adjust
behaviour, export the PMIC information to enable this.

This is specifically required to enable the RRADC to adjust
coefficients based on which chip fab the PMIC was produced in,
this can vary per unique device and therefore has to be read at
runtime.

Signed-off-by: Caleb Connolly <caleb.connolly@xxxxxxxxxx>
Hi Caleb,

Looks fine to me, though obviously needs a tag from Lee as MFD maintainer.
I'm assuming I'll take this series through IIO once everyone is happy
with the changes and hence it'll pick up my SoB, so I'm not giving
RBs or similar in the meantime.

Thanks,

Jonathan

--
Kind Regards,
Caleb (they/them)




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux