On Wed, Nov 10, 2021 at 04:29:00PM +0530, Bhupesh Sharma wrote: > Changes since v4: > ================= > - v4 for sm8250 can be seen here: https://lore.kernel.org/linux-arm-msm/20211013105541.68045-1-bhupesh.sharma@xxxxxxxxxx/ > - v1 for sm8150 qce enablement can be seen here: https://lore.kernel.org/linux-arm-msm/20211013165823.88123-1-bhupesh.sharma@xxxxxxxxxx/ > - Merged the sm8150 and sm8250 enablement patches in the same patchset, > as per suggestions from Bjorn. > - Dropped a couple of patches from v4, as these have been picked by > Bjorn already via his tree. > - Addressed review comments from Vladimir, Thara and Rob. > - Collect Reviewed-by from Rob and Thara on some of the patches from the > v4 patchset. > > Changes since v3: > ================= > - v3 can be seen here: https://lore.kernel.org/linux-arm-msm/20210519143700.27392-1-bhupesh.sharma@xxxxxxxxxx/ > - Dropped a couple of patches from v3, on basis of the review comments: > ~ [PATCH 13/17] crypto: qce: core: Make clocks optional > ~ [PATCH 15/17] crypto: qce: Convert the device found dev_dbg() to dev_info() > - Addressed review comments from Thara, Rob and Stephan Gerhold. > - Collect Reviewed-by from Rob and Thara on some of the patches from the > v3 patchset. > > Changes since v2: > ================= > - v2 can be seen here: https://lore.kernel.org/dmaengine/20210505213731.538612-1-bhupesh.sharma@xxxxxxxxxx/ > - Drop a couple of patches from v1, which tried to address the defered > probing of qce driver in case bam dma driver is not yet probed. > Replace it instead with a single (simpler) patch [PATCH 16/17]. > - Convert bam dma and qce crypto dt-bindings to YAML. > - Addressed review comments from Thara, Bjorn, Vinod and Rob. > > Changes since v1: > ================= > - v1 can be seen here: https://lore.kernel.org/linux-arm-msm/20210310052503.3618486-1-bhupesh.sharma@xxxxxxxxxx/ > - v1 did not work well as reported earlier by Dmitry, so v2 contains the following > changes/fixes: > ~ Enable the interconnect path b/w BAM DMA and main memory first > before trying to access the BAM DMA registers. > ~ Enable the interconnect path b/w qce crytpo and main memory first > before trying to access the qce crypto registers. > ~ Make sure to document the required and optional properties for both > BAM DMA and qce crypto drivers. > ~ Add a few debug related print messages in case the qce crypto driver > passes or fails to probe. > ~ Convert the qce crypto driver probe to a defered one in case the BAM DMA > or the interconnect driver(s) (needed on specific Qualcomm parts) are not > yet probed. > > Qualcomm crypto engine is also available on sm8150 and sm8250 SoCs. > The qce block supports hardware accelerated algorithms for encryption > and authentication. It also provides support for aes, des, 3des > encryption algorithms and sha1, sha256, hmac(sha1), hmac(sha256) > authentication algorithms. > > Tested the enabled crypto algorithms with cryptsetup test utilities > on sm8150-mtp, sa8155p-adp, sm8250-mtp and RB5 boards (see [1]) and > also with crypto self-tests, including the fuzz tests > (CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y). > > [1]. https://linux.die.net/man/8/cryptsetup > > Cc: Thara Gopinath <thara.gopinath@xxxxxxxxxx> > Cc: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > Cc: Rob Herring <robh+dt@xxxxxxxxxx> Extremely random drive-by. Bjorn pointed this series at me today and I verified that it works and works well on sm8250. I agree with the cleanups suggested but otherwise a very enthusiastic: Tested-by: Jordan Crouse <jorcrous@xxxxxxxxxx> One nitpick possibly for the documentation somewhere. When I tried this on my own I was using the reg base from the downstream kernel which is obviously wrong. Perhaps a line somewhere in the bindings about how you calculate the base address may help future porting efforts. Jordan
