On 2/10/2022 7:11 AM, Stephen Boyd wrote:
Quoting Satya Priya (2022-02-08 06:52:19)Add base DTS file for pm8008 with infra and regulator nodes. Signed-off-by: Satya Priya <quic_c_skakit@xxxxxxxxxxx> --- Changes in V4: - This is newly added in V4, to add all the pm8008 common stuff. Changes in V5: - Changed the mfd node names from pm8008_chip to pm8008_infra and pm8008_ldo to pm8008_regulators as they re more appropriate. - Changed the compatible for pm8008@9 mfd node to differentiate from pm8008@8 node in driver. - Removed compatible for regulators node. - Removed reg property for LDOs and added in driver. arch/arm64/boot/dts/qcom/pm8008.dtsi | 46 ++++++++++++++++++++++++++++++++++++ 1 file changed, 46 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/pm8008.dtsi diff --git a/arch/arm64/boot/dts/qcom/pm8008.dtsi b/arch/arm64/boot/dts/qcom/pm8008.dtsi new file mode 100644 index 0000000..8e04983 --- /dev/null +++ b/arch/arm64/boot/dts/qcom/pm8008.dtsi @@ -0,0 +1,46 @@ +// SPDX-License-Identifier: BSD-3-Clause +// Copyright (c) 2021, The Linux Foundation. All rights reserved. + +pm8008_infra: pm8008@8 { + compatible = "qcom,pm8008"; + reg = <0x8>; + #address-cells = <1>; + #size-cells = <0>; +}; + +pm8008_regulators: pm8008@9 { + compatible = "qcom,pm8008-regulators"; + reg = <0x9>; + #address-cells = <1>; + #size-cells = <0>; + + regulators {What is the point of the 'regulators' node? Why can't we just put LDO1 directly underneath the node that has the "qcom,pm8008-regulators" compatible?
It is not mandatory to have it but I think it makes the layout look a little better. And it seems to be commonly used upstream.
+ pm8008_l1: LDO1 { + regulator-name = "pm8008_l1"; + }; +
