On Thu, 3 Feb 2022 05:22:23 -0600 Alex Elder wrote:
> On 2/2/22 11:02 PM, Jakub Kicinski wrote:
> > On Tue, 1 Feb 2022 08:04:12 -0600 Alex Elder wrote:
> >> Fixes: 2775cbc5afeb6 ("net: ipa: rename "ipa_clock.c"")
> >
> > The Fixes tag should point at the place the code was introduced,
> > even if it moved or otherwise the patch won't apply as far back.
>
> The problem was not "activated" until this commit:
> 1aac309d32075 net: ipa: use autosuspend
>
>
> And that commit was merged together in a series that
> included the one I mentioned above:
> 2775cbc5afeb6 net: ipa: rename "ipa_clock.c"
>
> The rename commit is two commits after "use autosuspend".
>
> The merge commit was:
> 863434886497d Merge branch 'ipa-autosuspend'
>
>
> Until autosuspend is enabled, this new code is
> completely unnecessary, so back-porting it beyond
> that is pointless. I supplied the commit in the
> "Fixes" tag because I thought it would be close
> to equivalent and would avoid some trouble back-porting.
>
> Perhaps the "use autosuspend" commit is the one that
> should be in the "Fixes" tag, but I don't believe it
> should be back-ported any further than that.
>
> Re-spinning the series to fix the tag is trivial, but
> before I do that, can you tell me which commit you
> recommend I use in the "Fixes" tag?
>
> The original commit that introduced the microcontroller
> code (and also included the clock/power code) is:
> a646d6ec90983 soc: qcom: ipa: modem and microcontroller
Thanks for the explanation 1aac309d32075 sounds like the right choice.
Let me just swap it for you and apply the v2.
