Re: [PATCH v3 5/5] arm64: dts: qcom: msm8998: reserve potentially inaccessible clocks With the gcc driver now being more complete and describing clocks which might not always be write-accessible to the OS, conservatively specify all such clocks as protected in the SoC dts. The board dts - or even user-supplied dts - can override this property to reflect the actual configuration.

[Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>]

On Mon 24 Jan 06:18 CST 2022, michael.srba@xxxxxxxxx wrote:

> From: Michael Srba <michael.srba@xxxxxxxxx>
> 

Something is off with your $subject, perhaps the entire commit message
was treated as the subject?

> Signed-off-by: Michael Srba <Michael.Srba@xxxxxxxxx>
> ---
>  CHANGES:
>  - v2: add this patch
>  - v3: fix missing Signed-off-by
> ---
>  arch/arm64/boot/dts/qcom/msm8998.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
> index f273bc1ff629..cff83af8c12e 100644
> --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
> @@ -863,6 +863,12 @@ gcc: clock-controller@100000 {
>  
>  			clock-names = "xo", "sleep_clk";
>  			clocks = <&xo>, <&sleep_clk>;
> +
> +			// be conservative by default, the board dts
> +			// can overwrite this list

By next week we've forgotten why these clocks are listed here and then
it's not really going to help to know that it's a conservative list.

Please spell out why these clocks are listed here, and please use /* */

Thanks,
Bjorn

> +			protected-clocks = <AGGRE2_SNOC_NORTH_AXI>,
> +					   <SSC_XO>,
> +					   <SSC_CNOC_AHBS_CLK>;
>  		};
>  
>  		rpm_msg_ram: sram@778000 {
> -- 
> 2.34.1
>