Hi, On Thu, Jan 13, 2022 at 10:08 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote: > > Quoting Douglas Anderson (2022-01-13 16:43:00) > > When processing sc7280 device trees, I can see: > > > > Warning (simple_bus_reg): /soc@0/gmu@3d69000: > > simple-bus unit address format error, expected "3d6a000" > > > > There's a clear typo in the node name. Fix it. > > > > Fixes: 96c471970b7b ("arm64: dts: qcom: sc7280: Add gpu support") > > Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > > --- > > Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx> Thanks for all the reviews! > BTW, gmu isn't a "standard" node name so might be worth replacing that > with something else but I have no idea what. Maybe "firmware" or > "power-controller"? "gmu" matches what's in the "example" in Documentation/devicetree/bindings/display/msm/gmu.yaml. That was blessed by Rob Herring. If you think it should be something different, perhaps post a patch changing the example in the bindings? -Doug