Hi Bryan, Robert, On 12/22/21 2:37 AM, Bryan O'Donoghue wrote:
From: Jonathan Marek <jonathan@xxxxxxxx> Add bindings for qcom,sm8250-camss in order to support the camera subsystem for SM8250. Cc: devicetree@xxxxxxxxxxxxxxx Signed-off-by: Jonathan Marek <jonathan@xxxxxxxx> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> Reviewed-by: Rob Herring <robh@xxxxxxxxxx> --- .../bindings/media/qcom,sm8250-camss.yaml | 450 ++++++++++++++++++ 1 file changed, 450 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml diff --git a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
<snip>
+required: + - clock-names + - clocks + - compatible + - interconnects + - interconnect-names + - interrupts + - interrupt-names + - iommus + - power-domains + - reg + - reg-names + +additionalProperties: false
I've discovered that there is a noticeable difference between this bindings and all the previous ones, for instance see qcom,sdm845-camss.yaml There is no required 'vdda-supply' property on the list, and fwiw I believe there should be two supply properties for 0p9 and 1p2 supplies in fact. Similarly, two separate supplies should be present in sdm845 camss bindings. At the moment the driver operates with 'vdda' supply only, commit 9e5d1581 introduced undocumented 'vdd_sec' for sdm660, but, if I'm not mistaken, it's unused. In my opinion now it's a convenient moment to add descriptions and support of two vdda regulators, comments are more than welcome. -- Best wishes, Vladimir
