On Wed, 15 Dec 2021 at 23:09, Rob Clark <robdclark@xxxxxxxxx> wrote: > > On Wed, Dec 15, 2021 at 11:17 AM Dmitry Baryshkov > <dmitry.baryshkov@xxxxxxxxxx> wrote: > > > > On Wed, 15 Dec 2021 at 20:49, Rob Clark <robdclark@xxxxxxxxx> wrote: > > > > > > From: Rob Clark <robdclark@xxxxxxxxxxxx> > > > > > > Add UTS_RELEASE and show timestamp the same way for consistency. > > > > > > Signed-off-by: Rob Clark <robdclark@xxxxxxxxxxxx> > > > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > > > > --- > > > drivers/gpu/drm/msm/disp/msm_disp_snapshot.h | 4 ++-- > > > drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c | 9 ++++++--- > > > 2 files changed, 8 insertions(+), 5 deletions(-) > > > > We should pull this out of disp/, it's no longer disp-specific. > > Or possibly just move dsi/etc into disp? It is disp specific in the > sense that dumping GPU state works quite differently.. Not sure about this. dsi/hdmi/dp seem to be perfect top-level entities. I see your point here, however I'd rather prefer to move mdp4/mdp5/dpu1 out of disp subdir rather than pushing all non-GPU code into disp/ When I tried to move dsi/phy to a separate phy driver, I reworked msm_disp_snapshot by splitting some parts into lib/ code. But I can not say that I completely liked what I did. Partially it was one of the reasons for me not pushing the dsi/phy patchset past RFC. -- With best wishes Dmitry
