On Fri, 10 Dec 2021 02:26:52 +0000, Caleb Connolly wrote: > Add bindings for qcom PMIC SPMI haptics driver. > > Signed-off-by: Caleb Connolly <caleb@xxxxxxxxxxxxx> > --- > .../bindings/input/qcom,spmi-haptics.yaml | 123 ++++++++++++++++++ > include/dt-bindings/input/qcom,spmi-haptics.h | 32 +++++ > 2 files changed, 155 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/qcom,spmi-haptics.yaml > create mode 100644 include/dt-bindings/input/qcom,spmi-haptics.h > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/qcom,spmi-haptics.yaml: properties:qcom,wave-play-rate-us: '$ref' should not be valid under {'const': '$ref'} hint: Standard unit suffix properties don't need a type $ref from schema $id: http://devicetree.org/meta-schemas/core.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/qcom,spmi-haptics.yaml: ignoring, error in schema: properties: qcom,wave-play-rate-us warning: no schema found in file: ./Documentation/devicetree/bindings/input/qcom,spmi-haptics.yaml Documentation/devicetree/bindings/input/qcom,spmi-haptics.example.dt.yaml:0:0: /example-0/spmi/haptics@c000: failed to match any schema with compatible: ['qcom,pmi8998-haptics'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1566175 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.