On Tue, Apr 22, 2014 at 05:31:49PM -0700, Courtney Cavin wrote:
> From: Josh Cartwright <joshc@xxxxxxxxxxxxxx>
>
> The Qualcomm 8941 and 8841 PMICs are components used with the Snapdragon
> 800 series SoC family. This driver exists largely as a glue mfd component,
> it exists to be an owner of an SPMI regmap for children devices
> described in device tree.
>
> Signed-off-by: Josh Cartwright <joshc@xxxxxxxxxxxxxx>
> Signed-off-by: Courtney Cavin <courtney.cavin@xxxxxxxxxxxxxx>
Hey Courtney-
Thanks for picking this up!
One thing that I had meant to do is rename this thing. Nothing about
this is PM8841/PM8941 specific at all. It should apply equally to all
Qualcomm's PMICs which implement QPNP.
Perhaps a better name would be "qcom-pmic-qpnp".
[..]
> +++ b/drivers/mfd/pm8x41.c
> @@ -0,0 +1,63 @@
> +/* Copyright (c) 2013, The Linux Foundation. All rights reserved.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 and
> + * only version 2 as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + */
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/spmi.h>
> +#include <linux/regmap.h>
> +#include <linux/of_platform.h>
> +
> +static const struct regmap_config pm8x41_regmap_config = {
> + .reg_bits = 16,
> + .val_bits = 8,
> + .max_register = 0xFFFF,
> +};
This reminds me. David Collins (CC'd) noticed that there are usecases
where peripheral drivers will need to be accessing registers from atomic
context, so we should probably be setting .fast_io in the SPMI
regmap_bus structures, but we can tackle that when we get there.
> +
> +static int pm8x41_remove_child(struct device *dev, void *unused)
> +{
> + platform_device_unregister(to_platform_device(dev));
> + return 0;
> +}
> +
> +static void pm8x41_remove(struct spmi_device *sdev)
> +{
> + device_for_each_child(&sdev->dev, NULL, pm8x41_remove_child);
> +}
> +
> +static int pm8x41_probe(struct spmi_device *sdev)
> +{
> + struct regmap *regmap;
> +
> + regmap = devm_regmap_init_spmi_ext(sdev, &pm8x41_regmap_config);
> + if (IS_ERR(regmap)) {
> + dev_dbg(&sdev->dev, "regmap creation failed.\n");
> + return PTR_ERR(regmap);
> + }
> +
> + return of_platform_populate(sdev->dev.of_node, NULL, NULL, &sdev->dev);
> +}
> +
> +static const struct of_device_id pm8x41_id_table[] = {
> + { .compatible = "qcom,pm8841", },
> + { .compatible = "qcom,pm8941", },
> + {},
> +};
> +MODULE_DEVICE_TABLE(of, pm8x41_id_table);
I'm thinking we should probably have a generic compatible entry as well,
"qcom,pmic-qpnp" or similar. We should still specify in the binding
that PMIC slaves specify a version-specific string as well as the
generic string. That is, a slave should have:
compatible = "qcom,pm8841", "qcom,pmic-qpnp";
...in case we would ever need to differentiate in the future.
(I recall that in a previous version I had done this, but I don't
remember why I had changed it..)
Thanks again,
Josh
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
