On Fri, Apr 18, 2014 at 02:01:19AM +0300, Stanimir Vabanov wrote:
<snip>
> >
> > static const struct of_device_id bam_of_match[] = {
> > + { .compatible = "qcom,bam-v1.3.0", },
> > { .compatible = "qcom,bam-v1.4.0", },
>
> you could use the of_device_id::data field to switch between different
> versions.
>
> I mean this:
>
> static const struct of_device_id bam_of_match[] = {
> { .compatible = "qcom,bam-v1.3.0", .data = ®_offs_v1_3 },
> { .compatible = "qcom,bam-v1.4.0", .data = ®_offs_v1_4 },
> }
>
> and during .probe you will get the correct offsets per version. It then
> could be assigned to a variable in bdev.
>
> Then the defines could be:
>
> #define BAM_CTRL(bdev) (bdev->reg_offs->ctrl_offs + 0x00)
>
> I'm not sure how many additional code this will be but it looks clearer.
That's not a bad idea. I'll try this out and see how it looks.
--
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
