On 03/05/14 14:34, Sergei Shtylyov wrote: > Hello. > >> --- a/drivers/usb/phy/phy-msm-usb.c >> +++ b/drivers/usb/phy/phy-msm-usb.c > [...] >> @@ -235,12 +236,16 @@ static void ulpi_init(struct msm_otg *motg) >> >> static int msm_otg_link_clk_reset(struct msm_otg *motg, bool assert) >> { >> - int ret = 0; >> + int ret; >> >> - if (!motg->pdata->link_clk_reset) >> - return ret; >> + if (motg->pdata->link_clk_reset) >> + ret = motg->pdata->link_clk_reset(motg->clk, assert); >> + else >> + if (assert) > > Kernel style assumes: > > else if (assert) Thanks. will fix it. Regards, Ivan > >> + ret = reset_control_assert(motg->link_rst); >> + else >> + ret = reset_control_deassert(motg->link_rst); >> > [...] > > WBR, Sergei > > -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html