On Wed, Mar 05, 2014 at 01:02:29PM -0800, Stephen Boyd wrote:
> On 03/05/14 11:29, Josh Cartwright wrote:
> > Before performing additional cleanups to this driver, do the easy
> > cleanups first.
> >
> > Signed-off-by: Josh Cartwright <joshc@xxxxxxxxxxxxxx>
>
> Reviewed-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
Thanks for the reviews.
> > @@ -253,7 +253,7 @@ static int pm8xxx_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alarm)
> >
> > ctrl_reg = rtc_dd->ctrl_reg;
> > ctrl_reg = alarm->enabled ? (ctrl_reg | PM8xxx_RTC_ALARM_ENABLE) :
> > - (ctrl_reg & ~PM8xxx_RTC_ALARM_ENABLE);
> > + (ctrl_reg & ~PM8xxx_RTC_ALARM_ENABLE);
> >
> > rc = pm8xxx_write_wrapper(rtc_dd, &ctrl_reg, rtc_dd->rtc_base, 1);
> > if (rc < 0) {
>
> This could be better style with more lines:
>
> if (alarm->enabled)
> ctrl_reg |= PM8xxx_RTC_ALARM_ENABLE;
> else
> ctrl_reg &= ~PM8xxx_RTC_ALARM_ENABLE;
Agreed, I'll clean this up in a v2.
I might go back and see just how much can be cleanup up to use the
regmap_update_bits() API as well.
Thanks,
Josh
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
