> On 02/23/2014 11:15 PM, Saravana Kannan wrote:
> > The previous_freq value for a device could be an invalid frequency that
> > results in a error value being returned from devfreq_get_freq_level().
> > Check for an error value before using that to index into the transition
> > table.
> >
> > Not doing this check will result in memory corruption when previous_freq is
> > not a valid frequency.
> >
> > Signed-off-by: Saravana Kannan <skannan@xxxxxxxxxxxxxx>
>
> MyungJoo/Kyungmin,
>
> Would either of you have some time to respond to this?
>
> Thanks,
> Saravana
Dear Saravana,
> > + prev_lev = devfreq_get_freq_level(devfreq, devfreq->previous_freq);
> > + if (prev_lev < 0)
> > + return 0;
If devfreq_get_freq_level returned error, please return that error
to the caller. You are retuning 0 in that case.
Plus, do you think we are going to change profile->freq_table in run-time?
(by accidently? or intentionally?)
Cheers,
MyungJoo.
>
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> hosted by The Linux Foundation
>
>
>
>
>
>
>
ÿ淸º{.nÇ+돴윯돪†+%듚ÿ깁負¥Šwÿº{.nÇ+돴¥Š{깰ゆþk&þ)í끾èw* jgП¨ ¶‰šŽ듶¢jÿ¾?G«앶ÿ◀ ◁¦j:+v돣ŠwèjØm¶Ÿÿ ? ®w?듺þf＂·hš뤴얎ÿ녪¥
