On Fri, Feb 21, 2014 at 3:06 AM, Mark Rutland <mark.rutland@xxxxxxx> wrote: > On Fri, Feb 21, 2014 at 12:38:10AM +0000, Bjorn Andersson wrote: [...] > >> +static const struct of_device_id qup_i2c_dt_match[] = { >> + { .compatible = "qcom,i2c-qup-v1.1.1" }, >> + { .compatible = "qcom,i2c-qup-v2.1.1" }, >> + { .compatible = "qcom,i2c-qup-v2.2.1" }, > > The all seem to be handled the same. > > Are they all compatible with the "qcom,i2c-qup-v1.1.1" programming > model, such that it could be used as a fallback in the compatible list > (and the driver would only need to look for it for now)? The v2 model will get BAM (DMAEngine) support soon, v1 uses an older DMA core. So there's a difference. I'm not aware what differences there are between 2.1.1 and 2.2.1. Question is if next change will be called v3, as we then could skip the reset of the version. We could probably skip 2.1.1 as that's supposed to be the first revision of 8x74, with all the expected HW quirks...I.e. not sure if anyone should use that. Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html