On 01/09/14 23:05, Stephen Boyd wrote: > It feels another key point is being missed though. The regmap > pointer and the enable_reg/enable_mask is embedded in clk_hw to > allow the same code to be used by different types of surrounding > structs. Each struct: clk_pll, clk_rcg, and clk_branch in this > series use the regmap interface to enable/disable the clock and > they can easily do so by passing something that's always > available from struct clk_hw (be it via a wrapper struct, private > data member, or addition of new fields to clk_hw). If the regmap > members move into each specific type of clock we can't just pass > a single pointer to the enable/disable regmap functions anymore. > This is the reason why I suggested a driver data pointer or > container struct so that everything regmap related is contained > within one type. > Any thoughts? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
