On 12/24/2013 8:20 AM, Michal Nazarewicz wrote: > On Mon, Dec 23 2013, Manu Gautam <mgautam@xxxxxxxxxxxxxx> wrote: >> Allow userspace to pass SuperSpeed descriptors and >> handle them in the driver accordingly. >> This change doesn't modify existing desc_header and thereby >> keeps the ABI changes backward compatible i.e. existing >> userspace drivers compiled with old header (functionfs.h) >> would continue to work with the updated kernel. > > I'm mostly fine with this patch. If you change __ffs_func_bind_do_descs > as I've described inline, feel free to resend with: > > Acked-by: Michal Nazarewicz <mina86@xxxxxxxxxx> > > The other two minor issues are up to you. I don't have strong feelings. > Thanks. I have tried to address your comments in ver-5 of the patch that I just sent. -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html