On Fri, Aug 09, 2013 at 01:37:07PM -0700, Josh Cartwright wrote:
> +struct spmi_pmic_arb_dev {
> + struct spmi_controller controller;
> + struct device *dev;
> + struct device *slave;
This is problematic.
Why do you have the driver "own" the controller? What is dev for,
there's already a struct device within the controller. Same for slave,
what is it?
You have 3 struct devices here, which one controls the lifecycle of the
object (hint, I know the answer, but I think it's wrong...)
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
