Re: [PATCHv2] arm: mm: Use phys_addr_t properly for ioremap functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 15, 2013 at 04:15:39PM +0200, Arnd Bergmann wrote:
> On Tuesday 14 May 2013, Laura Abbott wrote:
> > Several of the ioremap functions use unsigned long in places
> > resulting in truncation if physical addresses greater than
> > 4G are passed in. Change the types of the functions and the
> > callers accordingly.
> 
> Looks good to me. I wonder a bit whether resource_size_t or phys_addr_t
> is the right type here, but they are always defined to the same type
> these days.
> 
> FWIW, x86 and tile use resource_size_t, while a couple of other architectures
> use phys_addr_t.

Maybe there's a project there for someone to remove phys_addr_t or
resource_size_t then - but I suspect Linus won't like the churn
caused by that...

So, let's just go by the one which takes less typing and save our
fingers.  phys_addr_t.
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux